actions-cool/issues-helper
1
0
Fork 0
mirror of https://gitea.com/Lydanne/issues-helper.git synced 2025-08-26 21:49:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove warning (#197)

Browse Source 
* fix: remove warning

* chore: update
This commit is contained in:
xrkffgg
2024-11-01 17:17:17 +08:00
committed by GitHub
parent f3eb0a0a96
commit 26a4993608
3 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/preview-build.yml vendored
View File

@@ -1,6 +1,6 @@
name: Preview Build name: Preview Build
on: on:
pull_request: pull_request:
types: [opened, synchronize, reopened] types: [opened, synchronize, reopened]
@@ -22,7 +22,7 @@ jobs:
zip -r dist.zip docs-dist zip -r dist.zip docs-dist
- name: upload dist artifact - name: upload dist artifact
uses: actions/upload-artifact@v2 uses: actions/upload-artifact@v4
with: with:
name: dist name: dist
path: dist.zip path: dist.zip
@@ -34,7 +34,7 @@ jobs:
- name: Upload PR number - name: Upload PR number
if: ${{ always() }} if: ${{ always() }}
uses: actions/upload-artifact@v2 uses: actions/upload-artifact@v4
with: with:
name: pr name: pr
path: ./pr-id.txt path: ./pr-id.txt

8
.github/workflows/preview-deploy.yml vendored
View File

@@ -12,7 +12,7 @@ jobs:
if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success' if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success'
steps: steps:
- name: download pr artifact - name: download pr artifact
uses: dawidd6/action-download-artifact@v2 uses: dawidd6/action-download-artifact@v6
with: with:
workflow: ${{ github.event.workflow_run.workflow_id }} workflow: ${{ github.event.workflow_run.workflow_id }}
name: pr name: pr
@@ -22,7 +22,7 @@ jobs:
run: echo "::set-output name=id::$(<pr-id.txt)" run: echo "::set-output name=id::$(<pr-id.txt)"
- name: download dist artifact - name: download dist artifact
uses: dawidd6/action-download-artifact@v2 uses: dawidd6/action-download-artifact@v6
with: with:
workflow: ${{ github.event.workflow_run.workflow_id }} workflow: ${{ github.event.workflow_run.workflow_id }}
workflow_conclusion: success workflow_conclusion: success
@@ -43,7 +43,7 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }} token: ${{ secrets.GITHUB_TOKEN }}
body: | body: |
🎊 PR Preview has been successfully built and deployed to https://issues-helper-preview-pr-${{ steps.pr.outputs.id }}.surge.sh 🎊 PR Preview has been successfully built and deployed to https://issues-helper-preview-pr-${{ steps.pr.outputs.id }}.surge.sh
<img width="300" src="https://user-images.githubusercontent.com/507615/90250366-88233900-de6e-11ea-95a5-84f0762ffd39.png"> <img width="300" src="https://user-images.githubusercontent.com/507615/90250366-88233900-de6e-11ea-95a5-84f0762ffd39.png">
<!-- Sticky Pull Request Comment --> <!-- Sticky Pull Request Comment -->
@@ -69,7 +69,7 @@ jobs:
if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'failure' if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'failure'
steps: steps:
- name: download pr artifact - name: download pr artifact
uses: dawidd6/action-download-artifact@v2 uses: dawidd6/action-download-artifact@v6
with: with:
workflow: ${{ github.event.workflow_run.workflow_id }} workflow: ${{ github.event.workflow_run.workflow_id }}
name: pr name: pr

2
src/helper/helper.ts
View File

@@ -80,8 +80,6 @@ export class IssueHelperEngine implements IIssueHelperEngine {
const issueNumber = core.getInput('issue-number') || defaultCtxNumber; const issueNumber = core.getInput('issue-number') || defaultCtxNumber;
if (issueNumber) { if (issueNumber) {
this.issueNumber = +issueNumber; this.issueNumber = +issueNumber;
} else {
core.warning(`'issue-number' is missing or this action not needed yet!`);
} }
this.emoji = core.getInput('emoji') || ''; this.emoji = core.getInput('emoji') || '';