refactor: further simplify discriminated union implementation

- Add event name constants to reduce duplication
- Derive EntityEventName and AutomationEventName types from constants
- Use isAutomationContext consistently in agent mode and registry
- Simplify parseGitHubContext by removing redundant type assertions
- Extract payload casts to variables for cleaner code

Co-Authored-By: Claude <noreply@anthropic.com>

src/github/context.ts

@@ -48,6 +48,10 @@ const ENTITY_EVENT_NAMES = [
 
 const AUTOMATION_EVENT_NAMES = ["workflow_dispatch", "schedule"] as const;
 
+// Derive types from constants for better maintainability
+type EntityEventName = typeof ENTITY_EVENT_NAMES[number];
+type AutomationEventName = typeof AUTOMATION_EVENT_NAMES[number];
+
 // Common fields shared by all context types
 type BaseContext = {
   runId: string;
@@ -78,12 +82,7 @@ type BaseContext = {
 
 // Context for entity-based events (issues, PRs, comments)
 export type ParsedGitHubContext = BaseContext & {
-  eventName:
+  eventName: EntityEventName;
-    | "issues"
-    | "issue_comment"
-    | "pull_request"
-    | "pull_request_review"
-    | "pull_request_review_comment";
   payload:
     | IssuesEvent
     | IssueCommentEvent
@@ -96,7 +95,7 @@ export type ParsedGitHubContext = BaseContext & {
 
 // Context for automation events (workflow_dispatch, schedule)
 export type AutomationContext = BaseContext & {
-  eventName: "workflow_dispatch" | "schedule";
+  eventName: AutomationEventName;
   payload: WorkflowDispatchEvent | ScheduleEvent;
 };
 
@@ -142,67 +141,68 @@ export function parseGitHubContext(): GitHubContext {
 
   switch (context.eventName) {
     case "issues": {
+      const payload = context.payload as IssuesEvent;
       return {
         ...commonFields,
-        eventName: "issues" as const,
+        eventName: "issues",
-        payload: context.payload as IssuesEvent,
+        payload,
-        entityNumber: (context.payload as IssuesEvent).issue.number,
+        entityNumber: payload.issue.number,
         isPR: false,
-      } as ParsedGitHubContext;
+      };
     }
     case "issue_comment": {
+      const payload = context.payload as IssueCommentEvent;
       return {
         ...commonFields,
-        eventName: "issue_comment" as const,
+        eventName: "issue_comment",
-        payload: context.payload as IssueCommentEvent,
+        payload,
-        entityNumber: (context.payload as IssueCommentEvent).issue.number,
+        entityNumber: payload.issue.number,
-        isPR: Boolean(
+        isPR: Boolean(payload.issue.pull_request),
-          (context.payload as IssueCommentEvent).issue.pull_request,
+      };
-        ),
-      } as ParsedGitHubContext;
     }
     case "pull_request": {
+      const payload = context.payload as PullRequestEvent;
       return {
         ...commonFields,
-        eventName: "pull_request" as const,
+        eventName: "pull_request",
-        payload: context.payload as PullRequestEvent,
+        payload,
-        entityNumber: (context.payload as PullRequestEvent).pull_request.number,
+        entityNumber: payload.pull_request.number,
         isPR: true,
-      } as ParsedGitHubContext;
+      };
     }
     case "pull_request_review": {
+      const payload = context.payload as PullRequestReviewEvent;
       return {
         ...commonFields,
-        eventName: "pull_request_review" as const,
+        eventName: "pull_request_review",
-        payload: context.payload as PullRequestReviewEvent,
+        payload,
-        entityNumber: (context.payload as PullRequestReviewEvent).pull_request
+        entityNumber: payload.pull_request.number,
-          .number,
         isPR: true,
-      } as ParsedGitHubContext;
+      };
     }
     case "pull_request_review_comment": {
+      const payload = context.payload as PullRequestReviewCommentEvent;
       return {
         ...commonFields,
-        eventName: "pull_request_review_comment" as const,
+        eventName: "pull_request_review_comment",
-        payload: context.payload as PullRequestReviewCommentEvent,
+        payload,
-        entityNumber: (context.payload as PullRequestReviewCommentEvent)
+        entityNumber: payload.pull_request.number,
-          .pull_request.number,
         isPR: true,
-      } as ParsedGitHubContext;
+      };
     }
     case "workflow_dispatch": {
       return {
         ...commonFields,
-        eventName: "workflow_dispatch" as const,
+        eventName: "workflow_dispatch",
         payload: context.payload as unknown as WorkflowDispatchEvent,
-      } as AutomationContext;
+      };
     }
     case "schedule": {
       return {
         ...commonFields,
-        eventName: "schedule" as const,
+        eventName: "schedule",
         payload: context.payload as unknown as ScheduleEvent,
-      } as AutomationContext;
+      };
     }
     default:
       throw new Error(`Unsupported event type: ${context.eventName}`);