anthropics/claude-code-action
1
0
Fork 0
mirror of https://github.com/anthropics/claude-code-action.git synced 2026-01-22 22:44:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: update branch naming convention for Kubernetes compatibility (#249)

Browse Source 
* refactor: update branch naming convention for Kubernetes compatibility

- Changed timestamp format in branch names to a shorter, Kubernetes-compatible style (lowercase, hyphens only).
- Updated related tests to reflect new branch name format.
- Ensured branch names are limited to a maximum of 50 characters to comply with Kubernetes naming requirements.

* refactor: clean up timestamp formatting in branch naming logic

- Removed unnecessary whitespace and standardized string formatting for the Kubernetes-compatible timestamp in branch names.
- Ensured consistency in the use of double quotes for string literals.
This commit is contained in:
Jay Derinbogaz
2025-07-12 20:30:49 +02:00
committed by GitHub
parent b6868bfc27
commit b92e56a96b
5 changed files with 70 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test/branch-cleanup.test.ts
View File

@@ -72,7 +72,7 @@ describe("checkAndCommitOrDeleteBranch", () => {
mockOctokit,
"owner",
"repo",
"claude/issue-123-20240101_123456",
"claude/issue-123-20240101-1234",
"main",
true, // commit signing enabled
);
@@ -80,7 +80,7 @@ describe("checkAndCommitOrDeleteBranch", () => {
expect(result.shouldDeleteBranch).toBe(true);
expect(result.branchLink).toBe("");
expect(consoleLogSpy).toHaveBeenCalledWith(
"Branch claude/issue-123-20240101_123456 has no commits from Claude, will delete it",
"Branch claude/issue-123-20240101-1234 has no commits from Claude, will delete it",
);
});
@@ -90,14 +90,14 @@ describe("checkAndCommitOrDeleteBranch", () => {
mockOctokit,
"owner",
"repo",
"claude/issue-123-20240101_123456",
"claude/issue-123-20240101-1234",
"main",
false,
);
expect(result.shouldDeleteBranch).toBe(false);
expect(result.branchLink).toBe(
`\n[View branch](${GITHUB_SERVER_URL}/owner/repo/tree/claude/issue-123-20240101_123456)`,
`\n[View branch](${GITHUB_SERVER_URL}/owner/repo/tree/claude/issue-123-20240101-1234)`,
);
expect(consoleLogSpy).not.toHaveBeenCalledWith(
expect.stringContaining("has no commits"),
@@ -123,14 +123,14 @@ describe("checkAndCommitOrDeleteBranch", () => {
mockOctokit,
"owner",
"repo",
"claude/issue-123-20240101_123456",
"claude/issue-123-20240101-1234",
"main",
false,
);
expect(result.shouldDeleteBranch).toBe(false);
expect(result.branchLink).toBe(
`\n[View branch](${GITHUB_SERVER_URL}/owner/repo/tree/claude/issue-123-20240101_123456)`,
`\n[View branch](${GITHUB_SERVER_URL}/owner/repo/tree/claude/issue-123-20240101-1234)`,
);
expect(consoleErrorSpy).toHaveBeenCalledWith(
"Error comparing commits on Claude branch:",
@@ -146,7 +146,7 @@ describe("checkAndCommitOrDeleteBranch", () => {
mockOctokit,
"owner",
"repo",
"claude/issue-123-20240101_123456",
"claude/issue-123-20240101-1234",
"main",
true, // commit signing enabled - will try to delete
);
@@ -154,7 +154,7 @@ describe("checkAndCommitOrDeleteBranch", () => {
expect(result.shouldDeleteBranch).toBe(true);
expect(result.branchLink).toBe("");
expect(consoleErrorSpy).toHaveBeenCalledWith(
"Failed to delete branch claude/issue-123-20240101_123456:",
"Failed to delete branch claude/issue-123-20240101-1234:",
deleteError,
);
});
@@ -170,7 +170,7 @@ describe("checkAndCommitOrDeleteBranch", () => {
mockOctokit,
"owner",
"repo",
"claude/issue-123-20240101_123456",
"claude/issue-123-20240101-1234",
"main",
false,
);
@@ -178,10 +178,10 @@ describe("checkAndCommitOrDeleteBranch", () => {
expect(result.shouldDeleteBranch).toBe(false);
expect(result.branchLink).toBe("");
expect(consoleLogSpy).toHaveBeenCalledWith(
"Branch claude/issue-123-20240101_123456 does not exist remotely",
"Branch claude/issue-123-20240101-1234 does not exist remotely",
);
expect(consoleLogSpy).toHaveBeenCalledWith(
"Branch claude/issue-123-20240101_123456 does not exist remotely, no branch link will be added",
"Branch claude/issue-123-20240101-1234 does not exist remotely, no branch link will be added",
);
});
});