From c13c2af69fd586212c85b363a830059ccacf09fe Mon Sep 17 00:00:00 2001 From: km-anthropic Date: Wed, 13 Aug 2025 10:18:17 -0700 Subject: [PATCH] Better fix: Control environment variables in agent test for predictable behavior --- test/modes/agent.test.ts | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/test/modes/agent.test.ts b/test/modes/agent.test.ts index 4dcf2b0..213d3b4 100644 --- a/test/modes/agent.test.ts +++ b/test/modes/agent.test.ts @@ -104,6 +104,12 @@ describe("Agent Mode", () => { eventName: "workflow_dispatch", }); + // Save original env vars and set test values + const originalHeadRef = process.env.GITHUB_HEAD_REF; + const originalRefName = process.env.GITHUB_REF_NAME; + delete process.env.GITHUB_HEAD_REF; + delete process.env.GITHUB_REF_NAME; + // Set CLAUDE_ARGS environment variable process.env.CLAUDE_ARGS = "--model claude-sonnet-4 --max-turns 10"; @@ -120,13 +126,12 @@ describe("Agent Mode", () => { expect(callArgs[1]).toContain("--mcp-config"); expect(callArgs[1]).toContain("--model claude-sonnet-4 --max-turns 10"); - // Verify return structure - branch will be whatever is in env or "main" as fallback - const expectedBranch = process.env.GITHUB_HEAD_REF || process.env.GITHUB_REF_NAME || "main"; + // Verify return structure - should use "main" as fallback when no env vars set expect(result).toEqual({ commentId: undefined, branchInfo: { baseBranch: "main", - currentBranch: expectedBranch, + currentBranch: "main", claudeBranch: undefined, }, mcpConfig: expect.any(String), @@ -134,6 +139,8 @@ describe("Agent Mode", () => { // Clean up delete process.env.CLAUDE_ARGS; + if (originalHeadRef !== undefined) process.env.GITHUB_HEAD_REF = originalHeadRef; + if (originalRefName !== undefined) process.env.GITHUB_REF_NAME = originalRefName; }); test("prepare method creates prompt file with correct content", async () => {