anthropics/claude-code-action
1
0
Fork 0
mirror of https://github.com/anthropics/claude-code-action.git synced 2026-01-22 22:44:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: enhance error logging in MCP server for better diagnostics

Browse Source 
- Add detailed error logging helper function
- Enhance error handling in commit_files and delete_files
- Capture GitHub request IDs for 500 errors
- Improve error message construction to avoid 'undefined'
- Add comprehensive logging for fetch errors and API responses
This commit is contained in:
Lina Tawfik
2025-05-23 17:05:16 -07:00
parent b02a95b3f3
commit cb9aae1881
1 changed files with 140 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

130
src/mcp/github-file-ops-server.ts
View File

@@ -1,5 +1,5 @@
#!/usr/bin/env node #!/usr/bin/env node
// GitHub File Operations MCP Server // GitHub File Operations MCP Server - Enhanced with detailed error logging
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js"; import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
import { StdioServerTransport } from "@modelcontextprotocol/sdk/server/stdio.js"; import { StdioServerTransport } from "@modelcontextprotocol/sdk/server/stdio.js";
import { z } from "zod"; import { z } from "zod";
@@ -52,6 +52,18 @@ const server = new McpServer({
version: "0.0.1", version: "0.0.1",
}); });
// Enhanced error logging helper
function logDetailedError(prefix: string, error: any) {
console.error(`[${prefix}] FULL ERROR CAUGHT:`, error);
console.error(`[${prefix}] Error type:`, typeof error);
console.error(`[${prefix}] Error constructor:`, error?.constructor?.name);
console.error(`[${prefix}] Error stack:`, error instanceof Error ? error.stack : 'No stack trace');
if (error && typeof error === 'object') {
console.error(`[${prefix}] Error properties:`, Object.keys(error));
console.error(`[${prefix}] Error JSON:`, JSON.stringify(error, null, 2));
}
}
// Commit files tool // Commit files tool
server.tool( server.tool(
"commit_files", "commit_files",
@@ -208,8 +220,14 @@ server.tool(
console.error(`[commit_files] Updating reference: ${updateRefUrl}`); console.error(`[commit_files] Updating reference: ${updateRefUrl}`);
console.error(`[commit_files] New commit SHA: ${newCommitData.sha}`); console.error(`[commit_files] New commit SHA: ${newCommitData.sha}`);
console.error(`[commit_files] Base SHA was: ${baseSha}`); console.error(`[commit_files] Base SHA was: ${baseSha}`);
console.error(`[commit_files] Request body:`, JSON.stringify({
sha: newCommitData.sha,
force: false,
}));
const updateRefResponse = await fetch(updateRefUrl, { let updateRefResponse;
try {
updateRefResponse = await fetch(updateRefUrl, {
method: "PATCH", method: "PATCH",
headers: { headers: {
Accept: "application/vnd.github+json", Accept: "application/vnd.github+json",
@@ -222,12 +240,27 @@ server.tool(
force: false, force: false,
}), }),
}); });
} catch (fetchError) {
console.error(`[commit_files] FETCH ERROR during reference update:`, fetchError);
logDetailedError('commit_files_fetch', fetchError);
throw new Error(`Network error during reference update: ${fetchError?.message || 'Unknown fetch error'}`);
}
console.error(`[commit_files] Update reference response status: ${updateRefResponse.status}`); console.error(`[commit_files] Update reference response status: ${updateRefResponse.status}`);
console.error(`[commit_files] Response headers:`, Object.fromEntries(updateRefResponse.headers.entries()));
if (!updateRefResponse.ok) { if (!updateRefResponse.ok) {
const errorText = await updateRefResponse.text(); let errorText;
try {
errorText = await updateRefResponse.text();
} catch (textError) {
console.error(`[commit_files] Failed to read error response text:`, textError);
errorText = 'Unable to read error response';
}
console.error(`[commit_files] Update reference error body: "${errorText}"`); console.error(`[commit_files] Update reference error body: "${errorText}"`);
console.error(`[commit_files] Error body length: ${errorText?.length}`);
console.error(`[commit_files] Error body type: ${typeof errorText}`);
// Log additional debugging info for 500 errors // Log additional debugging info for 500 errors
if (updateRefResponse.status === 500) { if (updateRefResponse.status === 500) {
@@ -235,6 +268,18 @@ server.tool(
console.error(`[commit_files] GitHub Request ID: ${requestId}`); console.error(`[commit_files] GitHub Request ID: ${requestId}`);
console.error(`[commit_files] This appears to be an internal GitHub error`); console.error(`[commit_files] This appears to be an internal GitHub error`);
console.error(`[commit_files] Token was valid for tree/commit creation but failed for ref update`); console.error(`[commit_files] Token was valid for tree/commit creation but failed for ref update`);
console.error(`[commit_files] Branch protection rules or permissions might be an issue`);
}
// Parse error if it's JSON
let parsedError;
try {
if (errorText && errorText.trim().startsWith('{')) {
parsedError = JSON.parse(errorText);
console.error(`[commit_files] Parsed error:`, parsedError);
}
} catch (e) {
console.error(`[commit_files] Error text is not JSON`);
} }
throw new Error( throw new Error(
@@ -264,9 +309,20 @@ server.tool(
], ],
}; };
} catch (error) { } catch (error) {
logDetailedError('commit_files', error);
const errorMessage = const errorMessage =
error instanceof Error ? error.message : String(error); error instanceof Error ? error.message : String(error);
console.error(`[commit_files] Error: ${errorMessage}`); console.error(`[commit_files] Final error message being thrown: "${errorMessage}"`);
// Ensure we're throwing a proper Error object with a message
if (!errorMessage || errorMessage === 'undefined' || errorMessage === '[object Object]') {
console.error(`[commit_files] WARNING: Error message is undefined or object, using fallback`);
const fallbackMessage = error instanceof Error && error.stack
? `Failed to commit files: ${error.stack.split('\n')[0]}`
: 'Failed to commit files: Unknown error occurred';
throw new Error(fallbackMessage);
}
throw new Error(errorMessage); throw new Error(errorMessage);
} }
}, },
@@ -407,11 +463,17 @@ server.tool(
// 6. Update the reference to point to the new commit // 6. Update the reference to point to the new commit
const updateRefUrl = `${GITHUB_API_URL}/repos/${owner}/${repo}/git/refs/heads/${branch}`; const updateRefUrl = `${GITHUB_API_URL}/repos/${owner}/${repo}/git/refs/heads/${branch}`;
console.error(`[commit_files] Updating reference: ${updateRefUrl}`); console.error(`[delete_files] Updating reference: ${updateRefUrl}`);
console.error(`[commit_files] New commit SHA: ${newCommitData.sha}`); console.error(`[delete_files] New commit SHA: ${newCommitData.sha}`);
console.error(`[commit_files] Base SHA was: ${baseSha}`); console.error(`[delete_files] Base SHA was: ${baseSha}`);
console.error(`[delete_files] Request body:`, JSON.stringify({
sha: newCommitData.sha,
force: false,
}));
const updateRefResponse = await fetch(updateRefUrl, { let updateRefResponse;
try {
updateRefResponse = await fetch(updateRefUrl, {
method: "PATCH", method: "PATCH",
headers: { headers: {
Accept: "application/vnd.github+json", Accept: "application/vnd.github+json",
@@ -424,19 +486,46 @@ server.tool(
force: false, force: false,
}), }),
}); });
} catch (fetchError) {
console.error(`[delete_files] FETCH ERROR during reference update:`, fetchError);
logDetailedError('delete_files_fetch', fetchError);
throw new Error(`Network error during reference update: ${fetchError?.message || 'Unknown fetch error'}`);
}
console.error(`[commit_files] Update reference response status: ${updateRefResponse.status}`); console.error(`[delete_files] Update reference response status: ${updateRefResponse.status}`);
console.error(`[delete_files] Response headers:`, Object.fromEntries(updateRefResponse.headers.entries()));
if (!updateRefResponse.ok) { if (!updateRefResponse.ok) {
const errorText = await updateRefResponse.text(); let errorText;
console.error(`[commit_files] Update reference error body: "${errorText}"`); try {
errorText = await updateRefResponse.text();
} catch (textError) {
console.error(`[delete_files] Failed to read error response text:`, textError);
errorText = 'Unable to read error response';
}
console.error(`[delete_files] Update reference error body: "${errorText}"`);
console.error(`[delete_files] Error body length: ${errorText?.length}`);
console.error(`[delete_files] Error body type: ${typeof errorText}`);
// Log additional debugging info for 500 errors // Log additional debugging info for 500 errors
if (updateRefResponse.status === 500) { if (updateRefResponse.status === 500) {
const requestId = updateRefResponse.headers.get('x-github-request-id'); const requestId = updateRefResponse.headers.get('x-github-request-id');
console.error(`[commit_files] GitHub Request ID: ${requestId}`); console.error(`[delete_files] GitHub Request ID: ${requestId}`);
console.error(`[commit_files] This appears to be an internal GitHub error`); console.error(`[delete_files] This appears to be an internal GitHub error`);
console.error(`[commit_files] Token was valid for tree/commit creation but failed for ref update`); console.error(`[delete_files] Token was valid for tree/commit creation but failed for ref update`);
console.error(`[delete_files] Branch protection rules or permissions might be an issue`);
}
// Parse error if it's JSON
let parsedError;
try {
if (errorText && errorText.trim().startsWith('{')) {
parsedError = JSON.parse(errorText);
console.error(`[delete_files] Parsed error:`, parsedError);
}
} catch (e) {
console.error(`[delete_files] Error text is not JSON`);
} }
throw new Error( throw new Error(
@@ -466,9 +555,20 @@ server.tool(
], ],
}; };
} catch (error) { } catch (error) {
logDetailedError('delete_files', error);
const errorMessage = const errorMessage =
error instanceof Error ? error.message : String(error); error instanceof Error ? error.message : String(error);
console.error(`[commit_files] Error: ${errorMessage}`); console.error(`[delete_files] Final error message being thrown: "${errorMessage}"`);
// Ensure we're throwing a proper Error object with a message
if (!errorMessage || errorMessage === 'undefined' || errorMessage === '[object Object]') {
console.error(`[delete_files] WARNING: Error message is undefined or object, using fallback`);
const fallbackMessage = error instanceof Error && error.stack
? `Failed to delete files: ${error.stack.split('\n')[0]}`
: 'Failed to delete files: Unknown error occurred';
throw new Error(fallbackMessage);
}
throw new Error(errorMessage); throw new Error(errorMessage);
} }
}, },