From feca21446a94067c0808b51de46774aafa8b57f5 Mon Sep 17 00:00:00 2001 From: "claude[bot]" <209825114+claude[bot]@users.noreply.github.com> Date: Fri, 30 May 2025 14:50:13 +0000 Subject: [PATCH] refactor: improve MCP config logging per review feedback - Remove configPreview from error logging to avoid cluttering output - Add informational log when merging MCP server configurations - Simplify error message for failed config parsing Co-authored-by: ashwin-ant --- src/mcp/install-mcp-server.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mcp/install-mcp-server.ts b/src/mcp/install-mcp-server.ts index 546fa0d..c49fb6e 100644 --- a/src/mcp/install-mcp-server.ts +++ b/src/mcp/install-mcp-server.ts @@ -51,6 +51,8 @@ export async function prepareMcpConfig( throw new Error("MCP config must be a valid JSON object"); } + core.info("Merging additional MCP server configuration with built-in servers"); + // Merge configurations with user config overriding built-in servers const mergedConfig = { ...baseMcpConfig, @@ -63,12 +65,8 @@ export async function prepareMcpConfig( return JSON.stringify(mergedConfig, null, 2); } catch (parseError) { - const configPreview = - additionalMcpConfig.length > 100 - ? `${additionalMcpConfig.substring(0, 100)}...` - : additionalMcpConfig; core.warning( - `Failed to parse additional MCP config: ${parseError}. Invalid config: "${configPreview}". Using base config only.`, + `Failed to parse additional MCP config: ${parseError}. Using base config only.`, ); } }