docker/buildx
1
0
Fork 0
mirror of https://gitea.com/Lydanne/buildx.git synced 2025-05-18 00:47:48 +08:00
Code Issues Packages Projects Releases 1 Wiki Activity

Add comment to document the purpose behind the non-standard handling of the error

Browse Source 
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
(cherry picked from commit 366328ba6ad1f930fbef1d2a52a274e0644960a4)
This commit is contained in:
Talon Bowler 2024-06-13 16:11:35 -07:00 committed by Tonis Tiigi
parent fe728e7780
commit 18fb636e2f
No known key found for this signature in database
GPG Key ID: AFA9DE5F8AB7AF39
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
commands/build.go
View File

@ -878,6 +878,12 @@ func printResult(f *controllerapi.PrintFunc, res map[string]string) error {
} }
} }
if lintResults.Error != nil { if lintResults.Error != nil {
// Print the error message and the source
// Normally, we would use `errdefs.WithSource` to attach the source to the
// error and let the error be printed by the handling that's already in place,
// but here we want to print the error in a way that's consistent with how
// the lint warnings are printed via the `lint.PrintLintViolations` function,
// which differs from the default error printing.
fmt.Println() fmt.Println()
lintBuf := bytes.NewBuffer([]byte(lintResults.Error.Message + "\n")) lintBuf := bytes.NewBuffer([]byte(lintResults.Error.Message + "\n"))
sourceInfo := lintResults.Sources[lintResults.Error.Location.SourceIndex] sourceInfo := lintResults.Sources[lintResults.Error.Location.SourceIndex]