bake: fix panic for unsupported hcl variable type

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
This commit is contained in:
CrazyMax 2022-12-01 00:52:05 +01:00
parent 3ed2783f34
commit 48b573e835
No known key found for this signature in database
GPG Key ID: 3248E46B6BB8C7F7
2 changed files with 13 additions and 1 deletions

View File

@ -782,3 +782,15 @@ func TestFunctionNoResult(t *testing.T) {
_, err := ParseFile(dt, "docker-bake.hcl")
require.Error(t, err)
}
func TestVarUnsupportedType(t *testing.T) {
dt := []byte(`
variable "FOO" {
default = []
}
target "default" {}`)
t.Setenv("FOO", "bar")
_, err := ParseFile(dt, "docker-bake.hcl")
require.Error(t, err)
}

View File

@ -241,7 +241,7 @@ func (p *parser) resolveValue(name string) (err error) {
return nil
} else {
// TODO: support lists with csv values
return errors.Errorf("unsupported type %s for variable %s", v.Type(), name)
return errors.Errorf("unsupported type %s for variable %s", vv.Type().FriendlyName(), name)
}
}
v = &vv