docker/buildx
1
0
Fork 0
mirror of https://gitea.com/Lydanne/buildx.git synced 2025-07-09 21:17:09 +08:00
Code Issues Packages Projects Releases 1 Wiki Activity

inspect: lazily load attestation data

Browse Source 
Delay loading the attestation data immediately, and only compute it upon
request. We do this using a deferred function which allows to define the
computation in the same place as before, but perform the computation
later.

With this patch, we ensure that the attestation data is only pulled from
the remote if it is actually referenced in the format string -
otherwise, we can skip it, for improved performance.

Signed-off-by: Justin Chadwell <me@jedevc.com>
This commit is contained in:
Justin Chadwell
2023-01-10 13:00:39 +00:00
parent 1d2ac78443
commit 56950ece69
2 changed files with 99 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
util/imagetools/printers.go
View File

@ -213,7 +213,10 @@ type tplInput struct {
}
func (inp tplInput) SBOM() (sbomStub, error) {
sbom := inp.result.SBOM()
sbom, err := inp.result.SBOM()
if err != nil {
return sbomStub{}, nil
}
for _, v := range sbom {
return v, nil
}
@ -221,7 +224,10 @@ func (inp tplInput) SBOM() (sbomStub, error) {
}
func (inp tplInput) Provenance() (provenanceStub, error) {
provenance := inp.result.Provenance()
provenance, err := inp.result.Provenance()
if err != nil {
return provenanceStub{}, nil
}
for _, v := range provenance {
return v, nil
}
@ -237,9 +243,9 @@ type tplInputs struct {
}
func (inp tplInputs) SBOM() (map[string]sbomStub, error) {
return inp.result.SBOM(), nil
return inp.result.SBOM()
}
func (inp tplInputs) Provenance() (map[string]provenanceStub, error) {
return inp.result.Provenance(), nil
return inp.result.Provenance()
}