commands: build summary of warnings on build

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This commit is contained in:
Tonis Tiigi
2021-12-18 22:08:43 -08:00
parent 54286a0117
commit ed4103ef52
5 changed files with 113 additions and 4 deletions

View File

@ -7,8 +7,10 @@ import (
"os"
"github.com/containerd/console"
"github.com/docker/buildx/util/logutil"
"github.com/moby/buildkit/client"
"github.com/moby/buildkit/util/progress/progressui"
"github.com/sirupsen/logrus"
)
const (
@ -19,9 +21,10 @@ const (
)
type Printer struct {
status chan *client.SolveStatus
done <-chan struct{}
err error
status chan *client.SolveStatus
done <-chan struct{}
err error
warnings []client.VertexWarning
}
func (p *Printer) Wait() error {
@ -34,6 +37,10 @@ func (p *Printer) Write(s *client.SolveStatus) {
p.status <- s
}
func (p *Printer) Warnings() []client.VertexWarning {
return p.warnings
}
func NewPrinter(ctx context.Context, out console.File, mode string) *Printer {
statusCh := make(chan *client.SolveStatus)
doneCh := make(chan struct{})
@ -58,8 +65,10 @@ func NewPrinter(ctx context.Context, out console.File, mode string) *Printer {
c = cons
}
}
resumeLogs := logutil.Pause(logrus.StandardLogger())
// not using shared context to not disrupt display but let is finish reporting errors
_, pw.err = progressui.DisplaySolveStatus(ctx, "", c, w, statusCh)
pw.warnings, pw.err = progressui.DisplaySolveStatus(ctx, "", c, w, statusCh)
resumeLogs()
close(doneCh)
}()
return pw