From f7992033bfa27c6bd7d1e87def7bef8270f36070 Mon Sep 17 00:00:00 2001 From: CrazyMax <1951866+crazy-max@users.noreply.github.com> Date: Mon, 17 Feb 2025 18:59:38 +0100 Subject: [PATCH] cache: fix gha cache url handling Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com> --- util/buildflags/cache.go | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/util/buildflags/cache.go b/util/buildflags/cache.go index f0c2a164..e9256900 100644 --- a/util/buildflags/cache.go +++ b/util/buildflags/cache.go @@ -207,6 +207,7 @@ func addGithubToken(ci *controllerapi.CacheOptionsEntry) { } version, ok := ci.Attrs["version"] if !ok { + // https://github.com/actions/toolkit/blob/2b08dc18f261b9fdd978b70279b85cbef81af8bc/packages/cache/src/internal/config.ts#L19 if v, ok := os.LookupEnv("ACTIONS_CACHE_SERVICE_V2"); ok { if b, err := strconv.ParseBool(v); err == nil && b { version = "2" @@ -218,15 +219,18 @@ func addGithubToken(ci *controllerapi.CacheOptionsEntry) { ci.Attrs["token"] = v } } + if _, ok := ci.Attrs["url_v2"]; !ok && version == "2" { + // https://github.com/actions/toolkit/blob/2b08dc18f261b9fdd978b70279b85cbef81af8bc/packages/cache/src/internal/config.ts#L34-L35 + if v, ok := os.LookupEnv("ACTIONS_RESULTS_URL"); ok { + ci.Attrs["url_v2"] = v + } + } if _, ok := ci.Attrs["url"]; !ok { - if version == "2" { - if v, ok := os.LookupEnv("ACTIONS_RESULTS_URL"); ok { - ci.Attrs["url_v2"] = v - } - } else { - if v, ok := os.LookupEnv("ACTIONS_CACHE_URL"); ok { - ci.Attrs["url"] = v - } + // https://github.com/actions/toolkit/blob/2b08dc18f261b9fdd978b70279b85cbef81af8bc/packages/cache/src/internal/config.ts#L28-L33 + if v, ok := os.LookupEnv("ACTIONS_CACHE_URL"); ok { + ci.Attrs["url"] = v + } else if v, ok := os.LookupEnv("ACTIONS_RESULTS_URL"); ok { + ci.Attrs["url"] = v } } }