docker/buildx
1
0
Fork 0
mirror of https://gitea.com/Lydanne/buildx.git synced 2025-05-18 09:17:49 +08:00
Code Issues Packages Projects Releases 1 Wiki Activity

Merge pull request #2100 from dvdksn/bake-empty-definition

Browse Source 
bake: improve error message for empty definition
This commit is contained in:
CrazyMax 2023-11-06 03:17:12 -08:00 committed by GitHub
commit ff8bca206b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
commands/bake.go
View File

@ -152,6 +152,10 @@ func runBake(dockerCli command.Cli, targets []string, in bakeOptions, cFlags com
return err return err
} }
if len(files) == 0 {
return errors.New("couldn't find a bake definition")
}
tgts, grps, err := bake.ReadTargets(ctx, files, targets, overrides, map[string]string{ tgts, grps, err := bake.ReadTargets(ctx, files, targets, overrides, map[string]string{
// don't forget to update documentation if you add a new // don't forget to update documentation if you add a new
// built-in variable: docs/bake-reference.md#built-in-variables // built-in variable: docs/bake-reference.md#built-in-variables

7
tests/bake.go
View File

@ -30,6 +30,7 @@ var bakeTests = []func(t *testing.T, sb integration.Sandbox){
testBakeRemoteCmdContextEscapeRelative, testBakeRemoteCmdContextEscapeRelative,
testBakeRemoteDockerfileCwd, testBakeRemoteDockerfileCwd,
testBakeRemoteLocalContextRemoteDockerfile, testBakeRemoteLocalContextRemoteDockerfile,
testBakeEmpty,
} }
func testBakeLocal(t *testing.T, sb integration.Sandbox) { func testBakeLocal(t *testing.T, sb integration.Sandbox) {
@ -477,3 +478,9 @@ COPY foo /foo
require.Error(t, err, out) require.Error(t, err, out)
require.Contains(t, out, "reading a dockerfile for a remote build invocation is currently not supported") require.Contains(t, out, "reading a dockerfile for a remote build invocation is currently not supported")
} }
func testBakeEmpty(t *testing.T, sb integration.Sandbox) {
out, err := bakeCmd(sb)
require.Error(t, err, out)
require.Contains(t, out, "couldn't find a bake definition")
}