86eb3be1c4
Merge pull request #3103 from thaJeztah/use_atomicwriter
...
migrate to use github.com/moby/sys/atomicwriter
2025-04-11 12:05:00 +02:00
5bac0b1197
build: print frontend inline message
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2025-04-11 09:45:25 +02:00
b7b5a3a1cc
migrate to use github.com/moby/sys/atomicwriter
...
The github.com/docker/docker/pkg/atomicwriter package was moved
to a separate module.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-04-10 12:13:01 +02:00
ef99381eab
otel: avoid tracing raw os arguments
...
User might pass a value that they don't expect to
be kept in trace storage. For example some cache backends
allow passing authentication tokens with a flag.
Instead use known primary config values as attributes
of the root span.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2025-03-17 18:14:52 +01:00
d5d3d3d502
lint: apply x/tools/modernize fixes
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2025-03-07 16:37:24 -08:00
cdfc1ed750
Merge pull request #2994 from tonistiigi/device-entitlements
...
support for device entitlement in build and bake
2025-02-18 22:28:23 +01:00
0c296fe857
support for device entitlement in build and bake
...
Allow access to CDI Devices in Buildkit v0.20.0+ for
devices that are not automatically allowed to be used by
everyone in BuildKit configuration.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2025-02-14 11:51:47 +01:00
b85fc5c484
vendor: github.com/docker/docker/v28.0.0-rc.1
...
full diff: https://github.com/docker/docker/compare/v27.5.1..v28.0.0-rc.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-02-13 13:53:44 +01:00
cee7b344da
Revert "vendor: github.com/docker/docker/v28.0.0-rc.1"
...
This reverts commit b195b80ddf1951866+crazy-max@users.noreply.github.com >
2025-02-11 18:14:49 +01:00
b195b80ddf
vendor: github.com/docker/docker/v28.0.0-rc.1
...
full diff: https://github.com/docker/docker/compare/v27.5.1..v28.0.0-rc.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-02-10 11:07:35 +01:00
b2ababc7b6
debug: fix invoke on error
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2025-01-31 10:45:34 +01:00
11c84973ef
buildflags: fix ref only format for command line and bake
...
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com >
2025-01-22 13:18:38 -06:00
ac636fd2d8
docs: missing quiet progress mode
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2025-01-13 15:13:18 +01:00
e7a53fb829
lint: enable forbidigo context rules
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-11-19 18:27:25 -08:00
c0fd64f4f8
lint: enable linters from buildkit
...
Skipping errname and testifylint
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-11-19 17:51:24 -08:00
be6d8326a8
Add ability to output json lists in metadata build file
...
Signed-off-by: Laurent Goderre <laurent.goderre@docker.com >
2024-11-11 16:36:45 -05:00
f89f861999
config: fix file/folder ownership
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-10-23 18:23:14 +02:00
b35a0f4718
protobuf: remove gogoproto
...
Removes gogo/protobuf from buildx and updates to a version of
moby/buildkit where gogo is removed.
This also changes how the proto files are generated. This is because
newer versions of protobuf are more strict about name conflicts. If two
files have the same name (even if they are relative paths) and are used
in different protoc commands, they'll conflict in the registry.
Since protobuf file generation doesn't work very well with
`paths=source_relative`, this removes the `go:generate` expression and
just relies on the dockerfile to perform the generation.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com >
2024-10-02 15:51:59 -05:00
671bd1b54d
Update to pass DockerMappingSrc and Dst in with Inputs, and return Inputs through Build
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com >
2024-09-18 20:56:31 -07:00
f1b92e9e6c
update Build commands to return dockerfile mapping for use in printing rule check warnings
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com >
2024-09-06 07:34:13 -07:00
7c481aae20
fix lint.PrintLintViolations signature change
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-09-04 18:44:07 +02:00
806ccd3545
print out the number of warnings after completing a rule check
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com >
2024-08-29 07:07:19 -07:00
d03c13b947
chore: rename PrintFunc to CallFunc
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-08-13 14:13:32 +02:00
6467a86427
Merge pull request #2610 from jsternberg/bake-metrics
...
metrics: add metrics for bake command
2024-08-09 10:05:05 +02:00
58571ff6d6
metrics: add metrics for bake command
...
This adds metrics for the bake command using a different method of
calculating the build identifier but with the same attributes otherwise.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com >
2024-08-08 10:00:11 -05:00
531c6d4ff1
support metadata file with call flag for build and bake commands
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-08-08 10:50:37 +02:00
cedbc5d68d
clarify the appropriate place to use the debug flag when viewing warnings
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com >
2024-07-18 08:36:34 -07:00
8f4c8b094a
bake: allow text descriptions for targets
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-07-03 09:54:03 -07:00
8da28574b0
bake: add call methods support and printing
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-07-03 09:54:02 -07:00
048ef1fbf8
fix: buildx b alias
...
the shorthand "b" alias was accidentally removed in 19d838a35727626+dvdksn@users.noreply.github.com >
2024-07-03 10:03:01 +02:00
19d838a3f4
docs: make buildx build the canonical doc
...
Move descriptions of flags common with the legacy build client to the buildx
build reference doc.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com >
2024-07-02 15:54:10 +02:00
2b17f277a1
Merge pull request #2549 from daghack/warning-free-msg
...
Add message when --check does not produce warnings or errors
2024-06-28 16:45:57 -07:00
f7a32361ea
use csvvalue package for parsing csv inputs
...
This package is better suited for parsing single-line
CSV strings.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-06-27 21:31:11 -07:00
b6482ab6bb
Add message when --check does not produce warnings or errors
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com >
2024-06-27 08:24:00 -07:00
f7bcafed21
build: opt to set progress warnings in response
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-06-26 06:53:35 +02:00
d155747029
build: read provenance response mode in commands pkg
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-06-24 14:32:26 +02:00
366328ba6a
Add comment to document the purpose behind the non-standard handling of the error
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com >
2024-06-13 16:11:35 -07:00
927fb6731c
update the lint subrequest call to error when a build error was encountered during linting
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com >
2024-06-13 09:47:05 -07:00
1e3aec1ae2
docs: mention rawjson progress output mode
...
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com >
2024-06-06 16:51:42 +02:00
ef4a165e48
commands: add an alias for --check to be the same as --call=check
...
This adds an alias for `--check` that causes it to behave the same as
`--call=check`. This is done using `BoolFunc` to call a function when
the option is seen and to set it to the correct value. This should allow
command line flags like `--check --call=targets` to work correctly (even
though they conflict) by making it so the first invocation sets the
print function to `check` and the second overwrites the first. This is
the expected behavior for these types of boolean flags.
`BoolFunc` itself is part of the standard library flags package, but
never seems to have made it into pflag possibly because it was added in
go 1.21.
https://pkg.go.dev/flag#FlagSet.BoolFunc
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com >
2024-06-03 13:25:21 -05:00
89810dc998
build: set default call method name to build
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-06-03 10:42:35 -07:00
250cd44d70
Adds a --call flag as an alias to the --print flag and hides the later.
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com >
2024-06-03 10:30:30 -07:00
4fc4bc07ae
vendor: update buildx to latest docker/cli
...
This version of docker/cli has changes to remove compose-cli wrapper and
move all CLI metrics to OTEL.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com >
2024-05-16 12:07:13 -05:00
1fb5d2a9ee
Merge pull request #2422 from crazy-max/skip-provenance-internal
...
build: don't generate metadata file when print flag is used
2024-04-29 17:12:20 -07:00
ba264138d6
build: don't generate metadata file when print flag is used
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-04-26 10:53:46 +02:00
b30566438b
lint: gopls fixes
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-04-24 17:58:17 -07:00
46c44c58ae
build: support statuscode response for print requests
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-04-15 10:38:54 -07:00
46cf94092c
commands: use vendored formatter for lint responses
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-04-11 07:52:07 -07:00
2e2f9f571f
build: set record provenance in response
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-04-11 10:11:27 +02:00
ffff87be03
build: fix stdin handling when building with controller
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-04-09 14:49:30 +02:00
