Remove the protobuf files associated with controller/errdefs.
This doesn't completely remove the type as the monitor still uses it as
a signal to start the monitor.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Before this patch, both "usage" and shell-completion scripts would preserve
the path of the invoked command, which was especially problematic for the
completion-scripts, because Cobra's completion depends on Command.Name()
for this (see [1], [2]);
./bin/build/buildx --help | head -n 5
Extended build capabilities with BuildKit
Usage:
./bin/build/buildx
./bin/build/buildx [command]
./bin/build/buildx completion bash | head -n 3
# bash completion V2 for ./bin/build/buildx -*- shell-script -*-
__./bin/build/buildx_debug()
This would also be problematic if the path contained a space, for example;
ln -s $(pwd)/bin/build $(pwd)/bin/Program\ Files
./bin/Program\ Files/buildx completion bash | head -n 3
# bash completion V2 for ./bin/Program -*- shell-script -*-
__./bin/Program_debug()
With this patch, the path is stripped to prevent this issue;
./bin/build/buildx --help | head -n 5
Extended build capabilities with BuildKit
Usage:
buildx
buildx [command]
./bin/build/buildx completion bash | head -n 3
# bash completion V2 for buildx -*- shell-script -*-
__buildx_debug()
./bin/Program\ Files/buildx completion bash | head -n 3
# bash completion V2 for buildx -*- shell-script -*-
__buildx_debug()
It's worth noting that this patch only fixes these basic issues. Other cases
are not yet addressed, and may need fixes in Cobra because (especially for
the completion scripts) it should likely not conflate "Name" with "executable".
For example, command.Name() does not handle situations where the executable
itself has a space in its name:
ln -s $(pwd)/bin/build/buildx $(pwd)/bin/build/hello\ world
./bin/build/hello\ world completion bash | head -n 3
# bash completion V2 for hello -*- shell-script -*-
__hello_debug()
Other, less problematic, issues to address are case-insensitive filesystems,
where the binary can be invoked with any case;
./bin/build/bUiLdX --help | head -n 5
Extended build capabilities with BuildKit
Usage:
bUiLdX
bUiLdX [command]
./bin/build/bUiLdX completion bash | head -n 3
# bash completion V2 for bUiLdX -*- shell-script -*-
__bUiLdX_debug()
[1]: https://github.com/spf13/cobra/blob/v1.8.1/bash_completionsV2.go#L24-L39
[2]: https://github.com/spf13/cobra/blob/v1.8.1/command.go#L1502-L1510
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
When run in standalone mode, the environment variables
`DOCKER_BUILDX_CPU_PROFILE` and `DOCKER_BUILDX_MEM_PROFILE` will cause
profiles to be written by the CLI.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Integrates vtproto into buildx. The generated files dockerfile has been
modified to copy the buildkit equivalent file to ensure files are laid
out in the appropriate way for imports.
An import has also been included to change the grpc codec to the version
in buildkit that supports vtproto. This will allow buildx to utilize the
speed and memory improvements from that.
Also updates the gc control options for prune.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Update buildkit dependency to v0.14.0-rc1. Update the tracing
infrastructure to use the new detect API which updates how the delegated
exporter is configured.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
This version of docker/cli has changes to remove compose-cli wrapper and
move all CLI metrics to OTEL.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Replace rules are not inherited by consumers of buildx as a module, and as
such would default to use the v0.26.2 version. Removing the replace rules
also removes various (indirect) dependencies (although brings in some new
packages from k8s itself).
The "azure" and "gcp" authentication packages in k8s.io/go-client are now
no longer functional, so removing those imports.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Kubernetes v1.26 removed the in-tree openstack cloud provider. While buildx
has a replace rule to pin the k8s dependencies to an older version, such
replace rules are non-transitive, which means that consumers of buildx as
a module could potentially end up with non-resolvable dependencies.
The used code was already non-functional since c41b006be1078aa358721b9a92e17eab9a51a958
(buildx v0.5.0-rc1);
a6b0959276/vendor/k8s.io/client-go/plugin/pkg/client/auth/openstack/openstack_stub.go (L26-L36)
See:
- 9bbf01bae9
- 98e81a7784
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This patch completes the work started in creating a remote driver:
- Renames the env driver to the remote driver (an alternative suggestion
that should be more user-friendly)
- Adds support for TLS to encrypt connections with buildkitd
- Fixes outstanding review comments
- Reworks the buildx create command endpoint construction to be clearer
and include better support for this new driver.
Signed-off-by: Justin Chadwell <me@jedevc.com>
Tested with `kind` and GKE.
Note: "nodes" shown in `docker buildx ls` are unrelated to Kubernetes "nodes".
Probably buildx should come up with an alternative term.
Usage:
$ kind create cluster
$ export KUBECONFIG="$(kind get kubeconfig-path --name="kind")"
$ docker buildx create --driver kubernetes --driver-opt replicas=3 --use
$ docker buildx build -t foo --load .
`--load` loads the image into the local Docker.
Driver opts:
- `image=IMAGE` - Sets the container image to be used for running buildkit.
- `namespace=NS` - Sets the Kubernetes namespace. Defaults to the current namespace.
- `replicas=N` - Sets the number of `Pod` replicas. Defaults to 1.
- `rootless=(true|false)` - Run the container as a non-root user without `securityContext.privileged`. Defaults to false.
- `loadbalance=(sticky|random)` - Load-balancing strategy. If set to "sticky", the pod is chosen using the hash of the context path. Defaults to "sticky"
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
To guard this Docker CLI plugin with docker's experimental CLI config,
buildx needs to be built with `go build -ldflags "-X main.experimental=1"`
Signed-off-by: Tibor Vass <tibor@docker.com>
