mirror of
https://gitea.com/Lydanne/buildx.git
synced 2025-05-18 00:47:48 +08:00

Previously, errors within the driver config would not be reported to the user until they tried to use the driver, even though they are easily accessible from the node group info. This patch reports these errors (but will not fail because of them, since the data is already saved) - this should help improve debuggability of some of the more complex drivers, and prevent error messages being suppressed. Signed-off-by: Justin Chadwell <me@jedevc.com>
320 lines
7.9 KiB
Go
320 lines
7.9 KiB
Go
package commands
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/csv"
|
|
"fmt"
|
|
"net/url"
|
|
"os"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/docker/buildx/driver"
|
|
"github.com/docker/buildx/store"
|
|
"github.com/docker/buildx/store/storeutil"
|
|
"github.com/docker/buildx/util/cobrautil"
|
|
"github.com/docker/buildx/util/confutil"
|
|
"github.com/docker/cli/cli"
|
|
"github.com/docker/cli/cli/command"
|
|
"github.com/google/shlex"
|
|
"github.com/moby/buildkit/util/appcontext"
|
|
"github.com/pkg/errors"
|
|
"github.com/sirupsen/logrus"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
type createOptions struct {
|
|
name string
|
|
driver string
|
|
nodeName string
|
|
platform []string
|
|
actionAppend bool
|
|
actionLeave bool
|
|
use bool
|
|
flags string
|
|
configFile string
|
|
driverOpts []string
|
|
bootstrap bool
|
|
// upgrade bool // perform upgrade of the driver
|
|
}
|
|
|
|
func runCreate(dockerCli command.Cli, in createOptions, args []string) error {
|
|
ctx := appcontext.Context()
|
|
|
|
if in.name == "default" {
|
|
return errors.Errorf("default is a reserved name and cannot be used to identify builder instance")
|
|
}
|
|
|
|
if in.actionLeave {
|
|
if in.name == "" {
|
|
return errors.Errorf("leave requires instance name")
|
|
}
|
|
if in.nodeName == "" {
|
|
return errors.Errorf("leave requires node name but --node not set")
|
|
}
|
|
}
|
|
|
|
if in.actionAppend {
|
|
if in.name == "" {
|
|
logrus.Warnf("append used without name, creating a new instance instead")
|
|
}
|
|
}
|
|
|
|
buildkitHost := os.Getenv("BUILDKIT_HOST")
|
|
|
|
driverName := in.driver
|
|
if driverName == "" {
|
|
if len(args) == 0 && buildkitHost != "" {
|
|
driverName = "remote"
|
|
} else {
|
|
var arg string
|
|
if len(args) > 0 {
|
|
arg = args[0]
|
|
}
|
|
f, err := driver.GetDefaultFactory(ctx, arg, dockerCli.Client(), true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if f == nil {
|
|
return errors.Errorf("no valid drivers found")
|
|
}
|
|
driverName = f.Name()
|
|
}
|
|
}
|
|
|
|
if driver.GetFactory(driverName, true) == nil {
|
|
return errors.Errorf("failed to find driver %q", in.driver)
|
|
}
|
|
|
|
txn, release, err := storeutil.GetStore(dockerCli)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer release()
|
|
|
|
name := in.name
|
|
if name == "" {
|
|
name, err = store.GenerateName(txn)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if !in.actionLeave && !in.actionAppend {
|
|
contexts, err := dockerCli.ContextStore().List()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, c := range contexts {
|
|
if c.Name == name {
|
|
logrus.Warnf("instance name %q already exists as context builder", name)
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
ng, err := txn.NodeGroupByName(name)
|
|
if err != nil {
|
|
if os.IsNotExist(errors.Cause(err)) {
|
|
if in.actionAppend && in.name != "" {
|
|
logrus.Warnf("failed to find %q for append, creating a new instance instead", in.name)
|
|
}
|
|
if in.actionLeave {
|
|
return errors.Errorf("failed to find instance %q for leave", name)
|
|
}
|
|
} else {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if ng != nil {
|
|
if in.nodeName == "" && !in.actionAppend {
|
|
return errors.Errorf("existing instance for %s but no append mode, specify --node to make changes for existing instances", name)
|
|
}
|
|
}
|
|
|
|
if ng == nil {
|
|
ng = &store.NodeGroup{
|
|
Name: name,
|
|
}
|
|
}
|
|
|
|
if ng.Driver == "" || in.driver != "" {
|
|
ng.Driver = driverName
|
|
}
|
|
|
|
var flags []string
|
|
if in.flags != "" {
|
|
flags, err = shlex.Split(in.flags)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to parse buildkit flags")
|
|
}
|
|
}
|
|
|
|
var ep string
|
|
var setEp bool
|
|
if in.actionLeave {
|
|
if err := ng.Leave(in.nodeName); err != nil {
|
|
return err
|
|
}
|
|
} else {
|
|
switch {
|
|
case driverName == "kubernetes":
|
|
// naming endpoint to make --append works
|
|
ep = (&url.URL{
|
|
Scheme: driverName,
|
|
Path: "/" + in.name,
|
|
RawQuery: (&url.Values{
|
|
"deployment": {in.nodeName},
|
|
"kubeconfig": {os.Getenv("KUBECONFIG")},
|
|
}).Encode(),
|
|
}).String()
|
|
setEp = false
|
|
case driverName == "remote":
|
|
if len(args) > 0 {
|
|
ep = args[0]
|
|
} else if buildkitHost != "" {
|
|
ep = buildkitHost
|
|
} else {
|
|
return errors.Errorf("no remote endpoint provided")
|
|
}
|
|
ep, err = validateBuildkitEndpoint(ep)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
setEp = true
|
|
case len(args) > 0:
|
|
ep, err = validateEndpoint(dockerCli, args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
setEp = true
|
|
default:
|
|
if dockerCli.CurrentContext() == "default" && dockerCli.DockerEndpoint().TLSData != nil {
|
|
return errors.Errorf("could not create a builder instance with TLS data loaded from environment. Please use `docker context create <context-name>` to create a context for current environment and then create a builder instance with `docker buildx create <context-name>`")
|
|
}
|
|
ep, err = storeutil.GetCurrentEndpoint(dockerCli)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
setEp = false
|
|
}
|
|
|
|
m, err := csvToMap(in.driverOpts)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if in.configFile == "" {
|
|
// if buildkit config is not provided, check if the default one is
|
|
// available and use it
|
|
if f, ok := confutil.DefaultConfigFile(dockerCli); ok {
|
|
logrus.Warnf("Using default BuildKit config in %s", f)
|
|
in.configFile = f
|
|
}
|
|
}
|
|
|
|
if err := ng.Update(in.nodeName, ep, in.platform, setEp, in.actionAppend, flags, in.configFile, m); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if err := txn.Save(ng); err != nil {
|
|
return err
|
|
}
|
|
|
|
if in.use && ep != "" {
|
|
current, err := storeutil.GetCurrentEndpoint(dockerCli)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if err := txn.SetCurrent(current, ng.Name, false, false); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
ngi := &nginfo{ng: ng}
|
|
|
|
timeoutCtx, cancel := context.WithTimeout(ctx, 20*time.Second)
|
|
defer cancel()
|
|
|
|
if err = loadNodeGroupData(timeoutCtx, dockerCli, ngi); err != nil {
|
|
return err
|
|
}
|
|
for _, info := range ngi.drivers {
|
|
if err := info.di.Err; err != nil {
|
|
logrus.Errorf("failed to initialize builder %s (%s): %s", ng.Name, info.di.Name, err)
|
|
}
|
|
}
|
|
|
|
if in.bootstrap {
|
|
if _, err = boot(ctx, ngi); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
fmt.Printf("%s\n", ng.Name)
|
|
return nil
|
|
}
|
|
|
|
func createCmd(dockerCli command.Cli) *cobra.Command {
|
|
var options createOptions
|
|
|
|
var drivers bytes.Buffer
|
|
for _, d := range driver.GetFactories() {
|
|
if len(drivers.String()) > 0 {
|
|
drivers.WriteString(", ")
|
|
}
|
|
drivers.WriteString(fmt.Sprintf(`"%s"`, d.Name()))
|
|
}
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "create [OPTIONS] [CONTEXT|ENDPOINT]",
|
|
Short: "Create a new builder instance",
|
|
Args: cli.RequiresMaxArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
return runCreate(dockerCli, options, args)
|
|
},
|
|
}
|
|
|
|
flags := cmd.Flags()
|
|
|
|
flags.StringVar(&options.name, "name", "", "Builder instance name")
|
|
flags.StringVar(&options.driver, "driver", "", fmt.Sprintf("Driver to use (available: %s)", drivers.String()))
|
|
flags.StringVar(&options.nodeName, "node", "", "Create/modify node with given name")
|
|
flags.StringVar(&options.flags, "buildkitd-flags", "", "Flags for buildkitd daemon")
|
|
flags.StringVar(&options.configFile, "config", "", "BuildKit config file")
|
|
flags.StringArrayVar(&options.platform, "platform", []string{}, "Fixed platforms for current node")
|
|
flags.StringArrayVar(&options.driverOpts, "driver-opt", []string{}, "Options for the driver")
|
|
flags.BoolVar(&options.bootstrap, "bootstrap", false, "Boot builder after creation")
|
|
|
|
flags.BoolVar(&options.actionAppend, "append", false, "Append a node to builder instead of changing it")
|
|
flags.BoolVar(&options.actionLeave, "leave", false, "Remove a node from builder instead of changing it")
|
|
flags.BoolVar(&options.use, "use", false, "Set the current builder instance")
|
|
|
|
// hide builder persistent flag for this command
|
|
cobrautil.HideInheritedFlags(cmd, "builder")
|
|
|
|
return cmd
|
|
}
|
|
|
|
func csvToMap(in []string) (map[string]string, error) {
|
|
m := make(map[string]string, len(in))
|
|
for _, s := range in {
|
|
csvReader := csv.NewReader(strings.NewReader(s))
|
|
fields, err := csvReader.Read()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
for _, v := range fields {
|
|
p := strings.SplitN(v, "=", 2)
|
|
if len(p) != 2 {
|
|
return nil, errors.Errorf("invalid value %q, expecting k=v", v)
|
|
}
|
|
m[p[0]] = p[1]
|
|
}
|
|
}
|
|
return m, nil
|
|
}
|