docker/buildx
1
0
Fork 0
mirror of https://gitea.com/Lydanne/buildx.git synced 2025-05-18 00:47:48 +08:00
Code Issues Packages Projects Releases 1 Wiki Activity

Mark span status as error when fatal error occurs.

Browse Source 
Before this only recorded errors instead of setting the span status,
which makes it harder to dig through.
Now an error that bubbles is reflected in the span status.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This commit is contained in:
Brian Goff 2021-10-21 22:24:51 +00:00
parent 084b6c0a95
commit b6474d43a9
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
build/build.go
View File

@ -217,8 +217,7 @@ func resolveDrivers(ctx context.Context, drivers []DriverInfo, auth Auth, opt ma
}
err = eg.Wait()
span.RecordError(err)
span.End()
tracing.FinishWithError(span, err)
if err != nil {
return nil, nil, err
}
@ -684,8 +683,7 @@ func Build(ctx context.Context, drivers []DriverInfo, opt map[string]Options, do
eg.Go(func() (err error) {
defer func() {
if span != nil {
span.RecordError(err)
span.End()
tracing.FinishWithError(span, err)
}
}()
pw := progress.WithPrefix(w, "default", false)