docker/buildx
1
0
Fork 0
mirror of https://gitea.com/Lydanne/buildx.git synced 2025-05-18 09:17:49 +08:00
Code Issues Packages Projects Releases 1 Wiki Activity

Merge pull request #812 from cpuguy83/mark_spans_as_error

Browse Source 
Mark span status as error when fatal error occurs.
This commit is contained in:
Tõnis Tiigi 2021-10-25 20:36:35 -07:00 committed by GitHub
commit be2c8f71fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
build/build.go
View File

@ -217,8 +217,7 @@ func resolveDrivers(ctx context.Context, drivers []DriverInfo, auth Auth, opt ma
} }
err = eg.Wait() err = eg.Wait()
span.RecordError(err) tracing.FinishWithError(span, err)
span.End()
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
} }
@ -684,8 +683,7 @@ func Build(ctx context.Context, drivers []DriverInfo, opt map[string]Options, do
eg.Go(func() (err error) { eg.Go(func() (err error) {
defer func() { defer func() {
if span != nil { if span != nil {
span.RecordError(err) tracing.FinishWithError(span, err)
span.End()
} }
}() }()
pw := progress.WithPrefix(w, "default", false) pw := progress.WithPrefix(w, "default", false)