docker/buildx
1
0
Fork 0
mirror of https://gitea.com/Lydanne/buildx.git synced 2025-07-02 09:28:36 +08:00
Code Issues Packages Projects Releases 1 Wiki Activity

Merge pull request #1869 from crazy-max/fix-boot

Browse Source 
builder: return error if all nodes fail to boot
This commit is contained in:
CrazyMax 2023-10-25 08:12:05 -07:00 committed by GitHub
commit e437f7ba04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builder/builder.go
View File

@ -165,6 +165,7 @@ func (b *Builder) Boot(ctx context.Context) (bool, error) {
baseCtx := ctx
eg, _ := errgroup.WithContext(ctx)
errCh := make(chan error, len(toBoot))
for _, idx := range toBoot {
func(idx int) {
eg.Go(func() error {
@ -172,6 +173,7 @@ func (b *Builder) Boot(ctx context.Context) (bool, error) {
_, err := driver.Boot(ctx, baseCtx, b.nodes[idx].Driver, pw)
if err != nil {
b.nodes[idx].Err = err
errCh <- err
}
return nil
})
@ -179,11 +181,15 @@ func (b *Builder) Boot(ctx context.Context) (bool, error) {
}
err = eg.Wait()
close(errCh)
err1 := printer.Wait()
if err == nil {
err = err1
}
if err == nil && len(errCh) == len(toBoot) {
return false, <-errCh
}
return true, err
}